> On Sept. 13, 2016, 4:34 p.m., Jonathan Hurley wrote:
> > I believe that the original case for this `hdp-select set all` was when 
> > adding a host back to the cluster after an upgrade. Because prior symlinks 
> > existed, new components will not have their symlink pointers created by 
> > RPM. We should make it explicit, perhaps, in a logged message that this is 
> > the side-effect of skipping this hdp-select set all call. 
> > 
> > However, we should be allowed to invoke `hdp-select set all` as many times 
> > as we want, especially since it's being done within a lock. Perhaps there 
> > needs to be a Jira to track why it's failing and have it gracefully recover.

I agree with Jonathan, if the symlinks are correct, "hdp-select set all" should 
be a no-op. I don't want to use this as a scapegoat for another underlying 
issue that we haven't discovered yet.


- Alejandro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51838/#review148735
-----------------------------------------------------------


On Sept. 13, 2016, 1:22 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51838/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 1:22 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Jayush Luniya, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18370
>     https://issues.apache.org/jira/browse/AMBARI-18370
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Modified Ambaripreupload.py to invoke 'hdp-select set all' to ensure that 
> when preparing a sysprepped host the stack selector tool was executed for the 
> selected HDP components
> 2. The shared initialisation script that is executed once after each HDP 
> component install as AFTER-install hook skips executing 'hdp-select set all' 
> if it's a sysprepped host
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 7c8c601 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  819d8f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  9982dc6 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  06a366e 
> 
> Diff: https://reviews.apache.org/r/51838/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> Python unit tests:
> ----------------------------------------------------------------------
> Total run:1125
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 1:43.849s
> [INFO] Finished at: Tue Sep 13 09:56:49 CEST 2016
> [INFO] Final Memory: 73M/799M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Reply via email to