> On Sept. 13, 2016, 8:42 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py,
> >  line 49
> > <https://reviews.apache.org/r/51838/diff/1/?file=1497560#file1497560line49>
> >
> >     Has this been tested on a sysprepped cluster that is deployed and then 
> > undergoes either one of these 2 operations:
> >     * add another service
> >     * perform an EU/RU (this may not be supported yet, but we need to be 
> > aware that we're using the host_sysprepped_flag to indicate a fresh install 
> > but the code still runs after an EU/RU).
> >     
> >     If those ops are not supported in sysprepped clusters, then close this 
> > issue.
> 
> Jayush Luniya wrote:
>     Wouldnt we be calling install_packages() during RU/EU? The after install 
> hook wouldnt be called during RU/EU.

Currently on sys_prepped cluster RU/EU is not supported. The after install hook 
is not invoked during RU/EU.


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51838/#review148757
-----------------------------------------------------------


On Sept. 14, 2016, 1:27 p.m., Sebastian Toader wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51838/
> -----------------------------------------------------------
> 
> (Updated Sept. 14, 2016, 1:27 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Jayush Luniya, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18370
>     https://issues.apache.org/jira/browse/AMBARI-18370
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> 1. Modified Ambaripreupload.py to invoke 'hdp-select set all' to ensure that 
> when preparing a sysprepped host the stack selector tool was executed for the 
> selected HDP components
> 2. The shared initialisation script that is executed once after each HDP 
> component install as AFTER-install hook skips executing 'hdp-select set all' 
> if it's a sysprepped host
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/scripts/Ambaripreupload.py 9492e17 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
>  819d8f7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
>  9982dc6 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/after-INSTALL/test_after_install.py
>  06a366e 
> 
> Diff: https://reviews.apache.org/r/51838/diff/
> 
> 
> Testing
> -------
> 
> Manual testing.
> 
> Python unit tests:
> ----------------------------------------------------------------------
> Total run:1125
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 1:43.849s
> [INFO] Finished at: Tue Sep 13 09:56:49 CEST 2016
> [INFO] Final Memory: 73M/799M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Reply via email to