> On 九月 16, 2016, 4:35 p.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java, > > line 72 > > <https://reviews.apache.org/r/51843/diff/4/?file=1499530#file1499530line72> > > > > After adding the missing import, the test fails at this line causes: > > > > ``` > > Running > > org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest > > Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 > > sec <<< FAILURE! - in > > org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest > > > > postScheduleTest(org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest) > > Time elapsed: 0.006 sec <<< FAILURE! > > java.lang.AssertionError: Nothing captured yet > > at > > org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73) > > ```
Hi Attila, thank you , I have update the diff ,and now it's OK - wang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51843/#review149209 ----------------------------------------------------------- On 九月 18, 2016, 9:20 a.m., wang yaoxin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51843/ > ----------------------------------------------------------- > > (Updated 九月 18, 2016, 9:20 a.m.) > > > Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, > and Sebastian Toader. > > > Bugs: AMBARI-18374 > https://issues.apache.org/jira/browse/AMBARI-18374 > > > Repository: ambari > > > Description > ------- > > when rolling restart services ( eg:DataNode ) ,cluster name in audit log show > null > > 2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), > Operation(Request from server), RequestType(POST), > url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 > Accepted), Command(RESTART), Cluster name(null) > > 2016-09-13T17:29:22.042+0800, User(admin), > Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), > RequestId(15) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java > 075e328 > > ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java > 1074f0e > > Diff: https://reviews.apache.org/r/51843/diff/ > > > Testing > ------- > > done! > > > Thanks, > > wang yaoxin > >