Hi Wang!

The patch is committed to trunk & branch-2.5, you can close now the related 
review request. Please make sure, next time to attach the result of unit tests 
to the Testing section of review request.

BR
Sandor

From: wang yaoxin 
<nore...@reviews.apache.org<mailto:nore...@reviews.apache.org>> on behalf of 
wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>
Reply-To: wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>
Date: Sunday 18 September 2016 11:21
To: Jonathan Hurley <jhur...@hortonworks.com<mailto:jhur...@hortonworks.com>>, 
Sebastian Toader <stoa...@hortonworks.com<mailto:stoa...@hortonworks.com>>, 
Oliver Szabo <osz...@hortonworks.com<mailto:osz...@hortonworks.com>>, Robert 
Nettleton <rnettle...@hortonworks.com<mailto:rnettle...@hortonworks.com>>
Cc: Sandor Magyari <smagy...@hortonworks.com<mailto:smagy...@hortonworks.com>>, 
Attila Doroszlai 
<adorosz...@hortonworks.com<mailto:adorosz...@hortonworks.com>>, wang yaoxin 
<wangyao...@cmss.chinamobile.com<mailto:wangyao...@cmss.chinamobile.com>>, 
Ambari <reviews@ambari.apache.org<mailto:reviews@ambari.apache.org>>
Subject: Re: Review Request 51843: rolling restart datanode cluster name in 
audit log show null

This is an automatically generated e-mail. To reply, visit: 
https://reviews.apache.org/r/51843/


On 九月 16th, 2016, 4:35 p.m. UTC, Attila Doroszlai wrote:

ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java<https://reviews.apache.org/r/51843/diff/4/?file=1499530#file1499530line72>(Diff
 revision 4)

        72

    AuditEvent event = AuditEventCreatorTestHelper.getEvent(creator, request, 
result);


After adding the missing import, the test fails at this line causes:

Running org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.161 sec <<< 
FAILURE! - in 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest
postScheduleTest(org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest)
  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Nothing captured yet
    at 
org.apache.ambari.server.audit.request.creator.RequestEventCreatorTest.postScheduleTest(RequestEventCreatorTest.java:73)


Hi Attila, thank you , I have update the diff ,and now it's OK


- wang


On 九月 18th, 2016, 9:20 a.m. UTC, wang yaoxin wrote:

Review request for Ambari, Jonathan Hurley, Oliver Szabo, Robert Nettleton, and 
Sebastian Toader.
By wang yaoxin.

Updated 九月 18, 2016, 9:20 a.m.

Bugs: AMBARI-18374<https://issues.apache.org/jira/browse/AMBARI-18374>
Repository: ambari
Description

when rolling restart services ( eg:DataNode ) ,cluster name in audit log show 
null

2016-09-13T17:29:22.033+0800, User(admin), RemoteIp(127.0.0.1), 
Operation(Request from server), RequestType(POST), 
url(http://localhost:8080/api/v1/clusters/amabri/requests), ResultStatus(202 
Accepted), Command(RESTART), Cluster name(null)

2016-09-13T17:29:22.042+0800, User(admin), 
Operation(PARSE.ROLLING-RESTART.DATANODE.1.1), Status(IN_PROGRESS), 
RequestId(15)


Testing

done!


Diffs

  *   
ambari-server/src/main/java/org/apache/ambari/server/audit/request/eventcreator/RequestEventCreator.java
 (075e328)
  *   
ambari-server/src/test/java/org/apache/ambari/server/audit/request/creator/RequestEventCreatorTest.java
 (1074f0e)

View Diff<https://reviews.apache.org/r/51843/diff/>

Reply via email to