----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review150852 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Сен. 29, 2016, 2:46 п.п., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52391/ > ----------------------------------------------------------- > > (Updated Сен. 29, 2016, 2:46 п.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18487 > https://issues.apache.org/jira/browse/AMBARI-18487 > > > Repository: ambari > > > Description > ------- > > 1. Change metric monitor sharding strategy to hostname based. > 2. Fix issues in AbstractTimelineMetricSink > 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > 426eb42 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java > 4d0ec14 > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java > b720ba9 > > ambari-metrics/ambari-metrics-hadoop-sink/src/test/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSinkTest.java > f44ca35 > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py > 3982c4e > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py > 050af16 > > Diff: https://reviews.apache.org/r/52391/diff/ > > > Testing > ------- > > Manually tested. > Unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
