----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52391/#review151213 -----------------------------------------------------------
ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py (line 149) <https://reviews.apache.org/r/52391/#comment219492> Will hostname_hash ever be negative? - Alejandro Fernandez On Oct. 3, 2016, 6:52 p.m., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52391/ > ----------------------------------------------------------- > > (Updated Oct. 3, 2016, 6:52 p.m.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-18487 > https://issues.apache.org/jira/browse/AMBARI-18487 > > > Repository: ambari > > > Description > ------- > > 1. Change metric monitor sharding strategy to hostname based. > 2. Fix issues in AbstractTimelineMetricSink - *Removed a change, since it was > already FIXED* > 3. Change Sink Zk retry policy to BoundedExponentialBackoffRetry. > > > Diffs > ----- > > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > fa5b694 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/availability/MetricCollectorHAHelper.java > 4d0ec14 > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/blacklisted_set.py > 3982c4e > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/config_reader.py > 3ca3a31 > > ambari-metrics/ambari-metrics-host-monitoring/src/main/python/core/emitter.py > 050af16 > > Diff: https://reviews.apache.org/r/52391/diff/ > > > Testing > ------- > > Manually tested. > Unit tests pass. > > > Thanks, > > Aravindan Vijayan > >
