-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52467/#review151124
-----------------------------------------------------------



- Ldap related changes are unnecessary, those are copied from an earlier 
version of ambari which will be deleted anyway, should not include it in these 
changes.
- also i do not think its needed to rename test-config to test-configs, i think 
keep that as is.

- Oliver Szabo


On Oct. 1, 2016, 10:43 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52467/
> -----------------------------------------------------------
> 
> (Updated Oct. 1, 2016, 10:43 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18510
>     https://issues.apache.org/jira/browse/AMBARI-18510
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logsearch looks for credentials also in it's own trust store, not only in 
> cacarts in case of external authentication
> 
> Other changes:
> - authentication cleanup
> - authentication unit tests added
> - trust store and key store handling moved to it's own class (SSLUtil)
> - docker test environment can be configured to use SSL for solr, and https 
> for logsearch portal
> - also removed non-existent LogProcessor.jar from the classpath of Log Search 
> and Log Feeder
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dfc7b7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  75d8be3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  c476b9d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  1844d8f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LdapProperties.java
>  2a1b4ee 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LdapPropertyName.java
>  370c94b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LdapUtil.java
>  6248e74 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
>  eab33a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
>  d37e545 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  7e146ac 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
>  51b3547 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProvider.java
>  ed4d7ef 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchLdapBindAuthenticator.java
>  10f7507 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
>  400361b 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 4e8901d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
>  fa3efb8 
>   ambari-logsearch/docker/.gitignore 0d6af58 
>   ambari-logsearch/docker/bin/start.sh a09e4b2 
>   ambari-logsearch/docker/logsearch-docker.sh 022b1ba 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml 52e3e2a 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh e69b1db 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties f930ec9 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> 7ac29dd 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hdfs.json
>  d975b0d 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-hst.json
>  4ccef74 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  aae0292 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-secure_log.json
>  93f6b1e 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-system_message.json
>  aef586d 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  122a9e1 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> 55fd36c 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml b80824b 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2ad7055 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 71c1a1c 
>   ambari-logsearch/docker/test-config/solr/log4j.properties adb2d9e 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh 92fa354 
>   ambari-logsearch/docker/test-config/solr/solr.xml 45f9c13 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg 48665ce 
>   ambari-logsearch/docker/test-configs/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logfeeder/logfeeder-env.sh 
> PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/global.config.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-hdfs.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-hst.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-secure_log.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-system_message.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-configs/logfeeder/shipper-conf/output.config.json
>  PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch-https/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch-https/logsearch-env.sh 
> PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch-https/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch/logsearch-env.sh 
> PRE-CREATION 
>   ambari-logsearch/docker/test-configs/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr-ssl/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr-ssl/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr-ssl/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr-ssl/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-configs/solr/zoo.cfg PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  d1c1ef9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  501603a 
> 
> Diff: https://reviews.apache.org/r/52467/diff/
> 
> 
> Testing
> -------
> 
> Tested in docker envrionment.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to