-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52467/#review151166
-----------------------------------------------------------


Ship it!




Ship It!

- Oliver Szabo


On Oct. 3, 2016, 1:08 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52467/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2016, 1:08 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18510
>     https://issues.apache.org/jira/browse/AMBARI-18510
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Logsearch looks for credentials also in it's own trust store, not only in 
> cacarts in case of external authentication
> 
> Other changes:
> - authentication cleanup
> - authentication unit tests added
> - trust store and key store handling moved to it's own class (SSLUtil)
> - docker test environment can be configured to use SSL for solr, and https 
> for logsearch portal
> - also removed non-existent LogProcessor.jar from the classpath of Log Search 
> and Log Feeder
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dfc7b7b 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/LogSearch.java
>  75d8be3 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ExternalServerClient.java
>  c476b9d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/PropertiesHelper.java
>  1844d8f 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/util/SSLUtil.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAbstractAuthenticationProvider.java
>  eab33a1 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProvider.java
>  d37e545 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProvider.java
>  7e146ac 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProvider.java
>  51b3547 
>   
> ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProvider.java
>  400361b 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh 4e8901d 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchExternalServerAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchFileAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchLdapAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/java/org/apache/ambari/logsearch/web/security/LogsearchSimpleAuthenticationProviderTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-portal/src/test/resources/logsearch.properties
>  fa3efb8 
>   ambari-logsearch/docker/.gitignore 0d6af58 
>   ambari-logsearch/docker/Dockerfile a09f235 
>   ambari-logsearch/docker/bin/start.sh a09e4b2 
>   ambari-logsearch/docker/logsearch-docker.sh 022b1ba 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh e69b1db 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh 2ad7055 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env-ssl.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh 92fa354 
>   
> ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/infra-solr-env.sh.j2
>  d1c1ef9 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  501603a 
> 
> Diff: https://reviews.apache.org/r/52467/diff/
> 
> 
> Testing
> -------
> 
> Tested in docker envrionment.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to