> On Oct. 14, 2016, 1:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 512 > > <https://reviews.apache.org/r/52839/diff/1/?file=1534966#file1534966line512> > > > > I'm curious - why use the configuration property getDefaultValue()? > > Shouldn't there be a Configuration accessor that actually checks for the > > property being set? > > Amarnath reddy pappu wrote: > I am not sure if having a configurable value would be useful in this > case. 5mins default value would be good enough i feel. > > do you think there may be customers who would want to enable the DEBUG > logs less than 5mins time? that is the only case i can think of. > > please advise so that I can proceed accordingly. > > Nate Cole wrote: > Well, this requested feature didn't originate with me :) It just seems > odd to have a configuration that could never be used.
If it's not configurable, why define a `ConfigurationProperty` instead of a plain `long` constant? - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52839/#review152595 ----------------------------------------------------------- On Oct. 13, 2016, 8:01 p.m., Amarnath reddy pappu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52839/ > ----------------------------------------------------------- > > (Updated Oct. 13, 2016, 8:01 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, > and Sid Wagle. > > > Bugs: AMBARI-18592 > https://issues.apache.org/jira/browse/AMBARI-18592 > > > Repository: ambari > > > Description > ------- > > Ability to enable the DEBUG logs in Ambari-server without server restart > > 1. PropertyConfigurator would check log4j.properties update every 5mins. if > there is any change in the file/timestamp it will reload the log4j > configurations. > 2. have defined to LOG4JMONITOR_DELAY for 5mins - 300000 milliseconds > 3. Have modified only for ambari-server > 4. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 378db18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > c05840e > > Diff: https://reviews.apache.org/r/52839/diff/ > > > Testing > ------- > > 1. Change the log4j.properties from INFO to DEBUG > [Expected Result] server should start logging the DEBUG logs with in 5mins of > time. > [Resutl] PASS > > 2. Change the log4j.properties from DEBUG to INFO > [Expected Result] server should reduce the logging to INFO mode with in 5mins > of time. > [Resutl] PASS > > > Thanks, > > Amarnath reddy pappu > >
