----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/#review153424 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (lines 72 - 75) <https://reviews.apache.org/r/53066/#comment222727> Don't do this; instead use a Provider<AmbariMetaInfo> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (line 152) <https://reviews.apache.org/r/53066/#comment222728> Make this a little easier and just return if the string is blank - no need to indent the entire method. ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java (lines 304 - 308) <https://reviews.apache.org/r/53066/#comment222729> Should we have an event for this to make it more de-coupled? A StackUpgradeCompletedEvent ? This way, the code here and down below gets centralized in a listener and you only need to fire the event. ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java (line 108) <https://reviews.apache.org/r/53066/#comment222730> JavaDoc. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py (lines 46 - 47) <https://reviews.apache.org/r/53066/#comment222733> I don't think this is needed ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py (line 48) <https://reviews.apache.org/r/53066/#comment222731> no need to check params.version - the compare_versions does that for you. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py (line 49) <https://reviews.apache.org/r/53066/#comment222734> Remove. ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py (line 199) <https://reviews.apache.org/r/53066/#comment222735> No need to check params.version - compare_versions does that already - Jonathan Hurley On Oct. 20, 2016, 12:26 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53066/ > ----------------------------------------------------------- > > (Updated Oct. 20, 2016, 12:26 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-18651 > https://issues.apache.org/jira/browse/AMBARI-18651 > > > Repository: ambari > > > Description > ------- > > Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select. Therefore, > the metainfo for ZKFC used {{<versionAdvertised>false</versionAdvertised>}}. > It was recently discovered that 2.5.0.0-1154+ has added this capability. > > * Change versionAdvertised > * Add code to ZKFC python to hdp-select. This code MUST check the > stack_feature to ensure that it is executed ONLY for HDP-2.5+ > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 87247eb > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > a07d0e6 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > 983cbdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 3e805a0 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py > aa0ab0f > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml > a3e4a64 > > Diff: https://reviews.apache.org/r/53066/diff/ > > > Testing > ------- > > few runs on live cluster > > > Thanks, > > Dmitro Lisnichenko > >
