----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53066/#review153710 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java (line 22) <https://reviews.apache.org/r/53066/#comment223132> The stack upgrade being finished should be its own event derived from ClusterEvent directly; doesn't make sense to make it a version change event since it's not based on components changing versions explicitely. ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java (line 74) <https://reviews.apache.org/r/53066/#comment223133> When checking versions, you can just use the enum AmbariEventType instead of instanceof. However, in this case since you're returning if it's not an instance of the event, why not just listen for the StackUpgradeFinishEvent directly? ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java (lines 92 - 96) <https://reviews.apache.org/r/53066/#comment223135> Same as above comment - why listen for a broader event, check instance type, and then return when you could just listen for the concrete event you care about? - Jonathan Hurley On Oct. 24, 2016, 12:35 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53066/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2016, 12:35 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-18651 > https://issues.apache.org/jira/browse/AMBARI-18651 > > > Repository: ambari > > > Description > ------- > > Previous to HDP-2.5.0.0, ZKFC was not included with hdp-select. Therefore, > the metainfo for ZKFC used {{<versionAdvertised>false</versionAdvertised>}}. > It was recently discovered that 2.5.0.0-1154+ has added this capability. > > * Change versionAdvertised > * Add code to ZKFC python to hdp-select. This code MUST check the > stack_feature to ensure that it is executed ONLY for HDP-2.5+ > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 1396bd8 > > ambari-server/src/main/java/org/apache/ambari/server/events/ChangeVersionEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/HostComponentVersionAdvertisedEvent.java > d40aade > > ambari-server/src/main/java/org/apache/ambari/server/events/StackUpgradeFinishEvent.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackUpgradeFinishListener.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/StackVersionListener.java > 87247eb > > ambari-server/src/main/java/org/apache/ambari/server/events/publishers/VersionEventPublisher.java > 5b32c4e > > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java > a07d0e6 > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponent.java > 983cbdf > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java > 3e805a0 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/zkfc_slave.py > aa0ab0f > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > dbde58b > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/metainfo.xml > a3e4a64 > > Diff: https://reviews.apache.org/r/53066/diff/ > > > Testing > ------- > > few runs on live cluster > > unit tests are being added > > > Thanks, > > Dmitro Lisnichenko > >
