> On Nov. 2, 2016, 11:10 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java, > > lines 2238-2241 > > <https://reviews.apache.org/r/53373/diff/1/?file=1551380#file1551380line2238> > > > > Interesting concept. I like the idea, but this will only work if we > > are one-cluster-at-a-time. If we ever invoke an upgrade against two > > clusters to the same version and one of them is orchestrating while the > > other is started (very highly unlikely today) this won't work. I wouldn't > > be opposed to putting it on the context. Your call. > > Jonathan Hurley wrote: > Bah! I had thought that the UpgradePack was new objects every time. > You're right that this would be problematic for concurrent upgrades. However, > since we don't have that problem now (and we could get around it in the > future by have a new UpgradPack instance for every upgrade), I think it's OK > to leave it.
Fair enough. - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154557 ----------------------------------------------------------- On Nov. 2, 2016, 12:32 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53373/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 12:32 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-18685 > https://issues.apache.org/jira/browse/AMBARI-18685 > > > Repository: ambari > > > Description > ------- > > Unit tests are in progress, but seeing as though this is a feature branch, I > didn't think I needed to wait to post the review. I mostly wanted feedback on > the approach before I invested time in the tests. > > Augment the API of creating an Upgrade with the following: > > ``` > POST api/v1/clusters/c1/upgrades > { > "Upgrade": { > "repository_version": "2.5.0.0-965", > "upgrade_type": "HOST_ORDERED", <---------- new value other than > ROLLING/NON_ROLLING > "skip_failures": "false", > "skip_prerequisite_checks": "false", > "skip_manual_verification": "false", > "host_order": [ <------ new > { > "hosts": [ "c6401.ambari.apache.org, "c6402.ambari.apache.org", > "c6403.ambari.apache.org" ], > "service_checks": ["ZOOKEEPER"] > }, > { > "hosts": [ "c6404.ambari.apache.org, "c6405.ambari.apache.org"], > "service_checks": ["ZOOKEEPER", "KAFKA"] > } > ] > } > } > ``` > > {{skip_failures}} must be {{false}} when the upgrade_type is HOST_ORDERED > {{skip_manual_verification}} must be omitted or {{false}} when upgrade_type > is HOST_ORDERED > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d83aaa2 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 32f5c42 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 9c75344 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderItem.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 9a0946b > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java > a72dd13 > > Diff: https://reviews.apache.org/r/53373/diff/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
