----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53373/#review154595 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Nov. 2, 2016, 4:32 p.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53373/ > ----------------------------------------------------------- > > (Updated Nov. 2, 2016, 4:32 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Nate Cole. > > > Bugs: AMBARI-18685 > https://issues.apache.org/jira/browse/AMBARI-18685 > > > Repository: ambari > > > Description > ------- > > Unit tests are in progress, but seeing as though this is a feature branch, I > didn't think I needed to wait to post the review. I mostly wanted feedback on > the approach before I invested time in the tests. > > Augment the API of creating an Upgrade with the following: > > ``` > POST api/v1/clusters/c1/upgrades > { > "Upgrade": { > "repository_version": "2.5.0.0-965", > "upgrade_type": "HOST_ORDERED", <---------- new value other than > ROLLING/NON_ROLLING > "skip_failures": "false", > "skip_prerequisite_checks": "false", > "skip_manual_verification": "false", > "host_order": [ <------ new > { > "hosts": [ "c6401.ambari.apache.org, "c6402.ambari.apache.org", > "c6403.ambari.apache.org" ], > "service_checks": ["ZOOKEEPER"] > }, > { > "hosts": [ "c6404.ambari.apache.org, "c6405.ambari.apache.org"], > "service_checks": ["ZOOKEEPER", "KAFKA"] > } > ] > } > } > ``` > > {{skip_failures}} must be {{false}} when the upgrade_type is HOST_ORDERED > {{skip_manual_verification}} must be omitted or {{false}} when upgrade_type > is HOST_ORDERED > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java > d83aaa2 > > ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java > 32f5c42 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > 9c75344 > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderItem.java > PRE-CREATION > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 9a0946b > > ambari-server/src/test/java/org/apache/ambari/server/state/stack/upgrade/StageWrapperBuilderTest.java > a72dd13 > > Diff: https://reviews.apache.org/r/53373/diff/ > > > Testing > ------- > > PENDING > > > Thanks, > > Jonathan Hurley > >
