----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53502/#review155137 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java (lines 176 - 177) <https://reviews.apache.org/r/53502/#comment224972> Could also create a proper Json Object that you set attributes on, but this will work as well. Please also add a test to make sure that the manual task indeed has the expected output. Likely in UpgradeHelperTest.testHostGroupingOrchestration() - Nate Cole On Nov. 4, 2016, 6:51 p.m., Duc Le wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53502/ > ----------------------------------------------------------- > > (Updated Nov. 4, 2016, 6:51 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-18681 > https://issues.apache.org/jira/browse/AMBARI-18681 > > > Repository: ambari > > > Description > ------- > > AMBARI-18681 Add host structured_out to manual task > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > b999f2f > > Diff: https://reviews.apache.org/r/53502/diff/ > > > Testing > ------- > > TBD > > > Thanks, > > Duc Le > >
