> On Nov. 8, 2016, 3:24 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java, > > line 179 > > <https://reviews.apache.org/r/53502/diff/3/?file=1556013#file1556013line179> > > > > I did mark it as Ship It, but I'm curious if we want to have this as a > > separate enum? > > Duc Le wrote: > If we don't use HostOrderActionType.HOST_UPGRADE, I would use a constant > string for now until we know better about what possible values of the enum > are. > > Jonathan Hurley wrote: > I think the original idea was to give a clue about why the upgrade was > holding and what needed to be done. HOST_UPGRADE is probably fine for this > (the original value in the Jira was `HOST_PREPARE` I think). > > Nate Cole wrote: > @Duc, when you're ready, I can commit this on your behalf. Just ping me > when ready.
@Nate, this should be ready, so please commit this change. I still can't update Jiras/attach patches yet. Thanks! - Duc ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53502/#review155291 ----------------------------------------------------------- On Nov. 8, 2016, 3:42 a.m., Duc Le wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53502/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 3:42 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate > Cole. > > > Bugs: AMBARI-18681 > https://issues.apache.org/jira/browse/AMBARI-18681 > > > Repository: ambari > > > Description > ------- > > AMBARI-18681 Add host structured_out to manual task > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/HostOrderGrouping.java > b999f2f > > ambari-server/src/test/java/org/apache/ambari/server/state/UpgradeHelperTest.java > 78969e4 > > Diff: https://reviews.apache.org/r/53502/diff/ > > > Testing > ------- > > Unit tests passing. > > ... > Tests run: 28, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 209.464 sec > - in org.apache.ambari.server.state.UpgradeHelperTest > ... > Tests run: 4727, Failures: 0, Errors: 0, Skipped: 42 > > > Thanks, > > Duc Le > >
