----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155436 -----------------------------------------------------------
Fix it, then Ship it! ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java (lines 136 - 138) <https://reviews.apache.org/r/53576/#comment225379> Missing break. ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java (line 740) <https://reviews.apache.org/r/53576/#comment225380> Do either the ClusterTopology or HostOfferResponse hold onto JPA entities? The reason I ask is that we have encountered EclispeLink problems when entities retrieved in one thread were "asynchronously processing" in another thread. I'm guessing that's not the case here, but it's something to ask. - Jonathan Hurley On Nov. 9, 2016, 5:27 a.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53576/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 5:27 a.m.) > > > Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-18569 > https://issues.apache.org/jira/browse/AMBARI-18569 > > > Repository: ambari > > > Description > ------- > > * Configurable number of threads > * Enable/disable flag > * Removed synchronization at bottlenecks > * Added cache for `StackEntity.findByNameAndVersion` query > * Added log for all 4 types of topology tasks > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 3103b6d > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 09e49ef > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 241a48f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 87eb266 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > a08d153 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c425969 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java > 2932581 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 6a65b48 > > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java > 3aaf589 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > bba0325 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > f90cf76 > > Diff: https://reviews.apache.org/r/53576/diff/ > > > Testing > ------- > > Created several clusters (size = 8-64 nodes) via blueprint > > > Thanks, > > Attila Doroszlai > >
