> On Nov. 10, 2016, 5:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java, > > line 1 > > <https://reviews.apache.org/r/53576/diff/3/?file=1559405#file1559405line1> > > > > I think if we want to change this, it should be project-wide ... and > > that means a new Jira and an update to the style wiki. > > > > However, it seems that Apache projects tend to use this format: > > > > https://github.com/apache/hadoop/blob/trunk/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/Content.java > > > > Is the dangling javadoc warning something in your IDE?
Even Ambari Server has both styles. From current trunk (b847a0c): ``` $ find ambari-server/src/main/java -type f -name '*.java' | xargs grep -n -m1 '^/*' | grep ':1:' | cut -f3 -d':' | sort | uniq -c 449 /* 1291 /** ``` - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53576/#review155601 ----------------------------------------------------------- On Nov. 9, 2016, 4:07 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53576/ > ----------------------------------------------------------- > > (Updated Nov. 9, 2016, 4:07 p.m.) > > > Review request for Ambari, Jonathan Hurley, Sandor Magyari, and Sebastian > Toader. > > > Bugs: AMBARI-18569 > https://issues.apache.org/jira/browse/AMBARI-18569 > > > Repository: ambari > > > Description > ------- > > * Configurable number of threads > * Enable/disable flag > * Removed synchronization at bottlenecks > * Added cache for `StackEntity.findByNameAndVersion` query > * Added log for all 4 types of topology tasks > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > f9557a5 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 09e49ef > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 241a48f > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostComponentResourceProvider.java > 87eb266 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java > a08d153 > > ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StackEntity.java > c425969 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostOfferResponse.java > 2932581 > > ambari-server/src/main/java/org/apache/ambari/server/topology/HostRequest.java > 6a65b48 > > ambari-server/src/main/java/org/apache/ambari/server/topology/LogicalRequest.java > 3aaf589 > > ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java > bba0325 > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > f90cf76 > > Diff: https://reviews.apache.org/r/53576/diff/ > > > Testing > ------- > > Created several clusters (size = 8-64 nodes) via blueprint > > > Thanks, > > Attila Doroszlai > >
