-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53588/
-----------------------------------------------------------
(Updated Nov. 9, 2016, 7:30 p.m.)
Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav
Papirkovskyy, and Sumit Mohanty.
Changes
-------
Thanks Jonathan Hurley for the review.
- Refactored to remove code dup.
- Enabled non-ssl connector always and two-way only if enabled
- Factored in the extra acceptors if both connectors enabled.
- Added Markdown.
Bugs: AMBARI-18827
https://issues.apache.org/jira/browse/AMBARI-18827
Repository: ambari
Description
-------
_Objectives_:
- Allow acceptors for agent and api connectors to be configurable
- The thread pool configuration did not take into account both 2-way and 1-way
connectors are configured for agent every time although only one is used and
not a mixed-mode. This causes insufficient threads in agent threadpool for a
high cpu core environment.
- Includes refactoring to remove code duplication.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
8857e19
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
ce3fe85
ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java
a1b5a6e
ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java
844f022
Diff: https://reviews.apache.org/r/53588/diff/
Testing
-------
Verified manually.
2-core VM ==>
Before patch:
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Acceptor"
| wc -l
4
[root@swagle-test-1 ~]# cat ~/jstack_before.out | grep "ambari-agent.*Selector"
| wc -l
4
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep
"ambari-client.*Acceptor" | wc -l
1
Default after patch:
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep
"ambari-client.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep
"ambari-agent.*Acceptor" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep
"ambari-client.*Selector" | wc -l
1
[root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep
"ambari-agent.*Selector" | wc -l
1
Setting configurations = 2:
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep
"ambari-agent.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep
"ambari-client.*Selector" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep
"ambari-agent.*Acceptor" | wc -l
2
[root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep
"ambari-client.*Acceptor" | wc -l
2
Thanks,
Sid Wagle
