> On Nov. 10, 2016, 9:58 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java, > > line 170 > > <https://reviews.apache.org/r/53588/diff/3/?file=1559695#file1559695line170> > > > > Can we keep these the same name as before? > > Sid Wagle wrote: > Ok, currently (2.4.2.0-101) we name agent threads as: qtp-ambari-agent > and client as ambari-client-thread. Both used QueuedThreadPool, this make it > consistent. > > Sid Wagle wrote: > Let me know if you are ok with naming them qtp-ambari-agent and > qtp-ambari-client vs qtp-ambari-agent and ambari-client-thread. Dropping the > issue for now.
If you want to change them back, then OK - I'll have to update a bunch of scripts I have which are used for evaluating jstacks. If there's no real reason to change them back to their old values, then I'd suggest leaving them. - Jonathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53588/#review155585 ----------------------------------------------------------- On Nov. 10, 2016, 1:27 p.m., Sid Wagle wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53588/ > ----------------------------------------------------------- > > (Updated Nov. 10, 2016, 1:27 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Myroslav > Papirkovskyy, and Sumit Mohanty. > > > Bugs: AMBARI-18827 > https://issues.apache.org/jira/browse/AMBARI-18827 > > > Repository: ambari > > > Description > ------- > > _Objectives_: > - Allow acceptors for agent and api connectors to be configurable > - The thread pool configuration did not take into account both 2-way and > 1-way connectors are configured for agent every time although only one is > used and not a mixed-mode. This causes insufficient threads in agent > threadpool for a high cpu core environment. > - Includes refactoring to remove code duplication. > > > Diffs > ----- > > ambari-server/docs/configuration/index.md 9d793ff > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > 6a4eabf > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > ce3fe85 > > ambari-server/src/main/java/org/apache/ambari/server/security/unsecured/rest/ConnectionInfo.java > a1b5a6e > > ambari-server/src/test/java/org/apache/ambari/server/configuration/ConfigurationTest.java > 844f022 > > Diff: https://reviews.apache.org/r/53588/diff/ > > > Testing > ------- > > Verified manually. > > 2-core VM ==> > Before patch: > [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep > "ambari-agent.*Acceptor" | wc -l > 4 > [root@swagle-test-1 ~]# cat ~/jstack_before.out | grep > "ambari-agent.*Selector" | wc -l > 4 > [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep > "ambari-client.*Selector" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_before.out | grep > "ambari-client.*Acceptor" | wc -l > 1 > > Default after patch: > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-client.*Acceptor" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-agent.*Acceptor" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-client.*Selector" | wc -l > 1 > [root@swagle-test-1 ambari-server]# cat ~/jstack_after.out | grep > "ambari-agent.*Selector" | wc -l > 1 > > Setting configurations = 2: > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-agent.*Selector" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-client.*Selector" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-agent.*Acceptor" | wc -l > 2 > [root@swagle-test-1 ambari-server]# cat ~/jstack_configured.out | grep > "ambari-client.*Acceptor" | wc -l > 2 > > > Thanks, > > Sid Wagle > >
