-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53663/#review155679
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
 (line 22)
<https://reviews.apache.org/r/53663/#comment225741>

    what happens if i want to add multiple custom labels/components to 
logsearch?



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 150)
<https://reviews.apache.org/r/53663/#comment225740>

    why add this is needed in this patch? 
    we should remove these with hst anyway after nifi/hst is updated. if ambari 
2.4 is used its there, for ambari 2.5 that wont be here



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 (line 70)
<https://reviews.apache.org/r/53663/#comment225743>

    why is that file deleted?


- Oliver Szabo


On Nov. 11, 2016, 12:39 a.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53663/
> -----------------------------------------------------------
> 
> (Updated Nov. 11, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-18854
>     https://issues.apache.org/jira/browse/AMBARI-18854
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Offer some properties in the logsearch configuration via which the user can 
> set up some other input logs in a similar way as the component logs.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py
>  2e9dda3 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  1f5064a 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  e90d623 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2
>  7e9153f 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py 
> 7a13637 
> 
> Diff: https://reviews.apache.org/r/53663/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to