> On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 150 > > <https://reviews.apache.org/r/53663/diff/1/?file=1561149#file1561149line150> > > > > why add this is needed in this patch? > > we should remove these with hst anyway after nifi/hst is updated. if > > ambari 2.4 is used its there, for ambari 2.5 that wont be here
Currently input.config-nifi.json.j2 is still present in the ambari-server project, so this should be in the params.py as well in order to be consistent. Or we may as well remove both, would that be OK? > On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py, > > line 70 > > <https://reviews.apache.org/r/53663/diff/1/?file=1561150#file1561150line70> > > > > why is that file deleted? Because if the user enters some custom input config first, and later deletes it then the generated custom input file should disappear too. To ensure this the file should be deleted every time, and potentially re-generated if there is some custom configured input. > On Nov. 11, 2016, 1:05 a.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml, > > line 22 > > <https://reviews.apache.org/r/53663/diff/1/?file=1561147#file1561147line22> > > > > what happens if i want to add multiple custom labels/components to > > logsearch? This solution supports only one label, which may have as many components/logs as we wish for. Do we want to allow the user to add multiple labels tis way? That would be a bit tricky, but certainly possible. - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53663/#review155679 ----------------------------------------------------------- On Nov. 11, 2016, 12:39 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53663/ > ----------------------------------------------------------- > > (Updated Nov. 11, 2016, 12:39 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty. > > > Bugs: AMBARI-18854 > https://issues.apache.org/jira/browse/AMBARI-18854 > > > Repository: ambari > > > Description > ------- > > Offer some properties in the logsearch configuration via which the user can > set up some other input logs in a similar way as the component logs. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_config_aggregator.py > 2e9dda3 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 1f5064a > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > e90d623 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/HadoopServiceConfig.json.j2 > 7e9153f > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py > 7a13637 > > Diff: https://reviews.apache.org/r/53663/diff/ > > > Testing > ------- > > Tested on local cluster. > > > Thanks, > > Miklos Gergely > >
