-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53854/#review156296
-----------------------------------------------------------


Fix it, then Ship it!





ambari-agent/src/main/python/ambari_agent/AmbariAgent.py (line 59)
<https://reviews.apache.org/r/53854/#comment226517>

    This will most likely kill child processes started by agent like 
datanode/namenode etc. I think they are in the same process group.
    Can you please check?


- Andrew Onischuk


On Nov. 18, 2016, 1:05 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53854/
> -----------------------------------------------------------
> 
> (Updated Nov. 18, 2016, 1:05 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-18922
>     https://issues.apache.org/jira/browse/AMBARI-18922
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Ambari agent auto-restart fails
> 
> 
> Diffs
> -----
> 
>   ambari-agent/src/main/python/ambari_agent/AmbariAgent.py d701e49 
>   ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 5d3607a 
>   ambari-agent/src/test/python/ambari_agent/TestAmbariAgent.py 1be487c 
> 
> Diff: https://reviews.apache.org/r/53854/diff/
> 
> 
> Testing
> -------
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to