----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53854/#review156318 -----------------------------------------------------------
Fix it, then Ship it! ambari-agent/src/main/python/ambari_agent/AmbariAgent.py (lines 52 - 59) <https://reviews.apache.org/r/53854/#comment226535> Does the os.killpg need to be in a finally? - Jonathan Hurley On Nov. 18, 2016, 8:05 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53854/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2016, 8:05 a.m.) > > > Review request for Ambari, Andrew Onischuk, Jonathan Hurley, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-18922 > https://issues.apache.org/jira/browse/AMBARI-18922 > > > Repository: ambari > > > Description > ------- > > Ambari agent auto-restart fails > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/AmbariAgent.py d701e49 > ambari-agent/src/main/python/ambari_agent/StatusCommandsExecutor.py 5d3607a > ambari-agent/src/test/python/ambari_agent/TestAmbariAgent.py 1be487c > > Diff: https://reviews.apache.org/r/53854/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
