-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53977/
-----------------------------------------------------------

Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Sebastian 
Toader, and Sid Wagle.


Bugs: AMBARI-18956
    https://issues.apache.org/jira/browse/AMBARI-18956


Repository: ambari


Description
-------

`EntityTransaction` may be marked 
[rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly())
 due to exception.  If `@Transactional` is not marked to `rollbackOn` such 
exception, Ambari still attempts to commit the transaction.  The end result for 
the transaction is the same (rollback), but instead of the original exception a 
`RollbackException` is reported, so information is lost.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java
 d7ba463 
  
ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/53977/diff/


Testing
-------

* Added unit test
* Tested on live cluster by triggering the downscale problem


Thanks,

Attila Doroszlai

Reply via email to