> On Nov. 30, 2016, 9:25 p.m., Sid Wagle wrote: > > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java, > > line 130 > > <https://reviews.apache.org/r/53977/diff/1/?file=1568455#file1568455line130> > > > > Line length too long, generally Ambari codebase has too many violations > > to count but can you retrict to something like 200 chars for consistency?
Or 120. - Sid ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53977/#review157468 ----------------------------------------------------------- On Nov. 29, 2016, 7:19 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53977/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 7:19 p.m.) > > > Review request for Ambari, Laszlo Puskas, Myroslav Papirkovskyy, Oliver > Szabo, Sandor Magyari, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-18956 > https://issues.apache.org/jira/browse/AMBARI-18956 > > > Repository: ambari > > > Description > ------- > > `EntityTransaction` may be marked > [rollback-only](http://docs.oracle.com/javaee/6/api/javax/persistence/EntityTransaction.html#setRollbackOnly()) > due to exception. If `@Transactional` is not marked to `rollbackOn` such > exception, Ambari still attempts to commit the transaction. The end result > for the transaction is the same (rollback), but instead of the original > exception a `RollbackException` is reported, so information is lost. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptor.java > d7ba463 > > ambari-server/src/test/java/org/apache/ambari/server/orm/AmbariJpaLocalTxnInterceptorTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/53977/diff/ > > > Testing > ------- > > * Added unit test > * Tested on live cluster by triggering the downscale problem > > > Thanks, > > Attila Doroszlai > >
