> On Nov. 28, 2016, 7:11 p.m., Dmitro Lisnichenko wrote: > > Current patch preview contains: > > * Inconsistency for table hostcomponentdesiredstate and hostcomponentstate > > for stack upgrade (seems to work) > > * Schema name in postgres is not ambari (we print warnings for any DB type, > > is it ok?) > > * Engine type check for MySQL (not well-tested yet). Should we check engine > > type for every table, or just for entire schema?
Current patch preview contains: - Inconsistency for table hostcomponentdesiredstate and hostcomponentstate for stack upgrade (seems to work) - Schema name in postgres is not ambari (we print warnings for any DB type, is it ok?) - Engine type check for MySQL (not well-tested yet). Should we check engine type for every table, or just for entire schema? - Dmitro ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/#review157059 ----------------------------------------------------------- On Nov. 28, 2016, 7:10 p.m., Dmitro Lisnichenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54080/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 7:10 p.m.) > > > Review request for Ambari, Jonathan Hurley and Nate Cole. > > > Bugs: AMBARI-18990 > https://issues.apache.org/jira/browse/AMBARI-18990 > > > Repository: ambari > > > Description > ------- > > Proposed auto-fixes > *Inconsistency for table hostcomponentdesiredstate and hostcomponentstate for > stack upgrade. > *Deleted services cause config table inconsistent > *Primary key constrain issue from old Ambari version > *Schema name in postgres is not ambari > *Inconsistency view > > # If there are missing states (service, component, host), etc, then > automatically add one with a value of UNKNOWN or INSTALLED. > # If there are no selected configs, then select the latest ones (could be a > bit dangerous) > # If there are multiple selected configs for the same type, then unselect all > but the most recent (could be a bit dangerous) > > For dangerous options, by default fail with warning, and provide console > option to perform fixes anyway (like the fsck does) > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 9c3ae5c > > ambari-server/src/main/java/org/apache/ambari/server/checks/MissedHostComponentState.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/54080/diff/ > > > Testing > ------- > > Work is still in progress. Publishing current patch to get early feedback > > > Thanks, > > Dmitro Lisnichenko > >
