----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54080/ -----------------------------------------------------------
(Updated Dec. 6, 2016, 6:24 p.m.) Review request for Ambari, Jonathan Hurley and Nate Cole. Changes ------- Final implementation Summary (updated) ----------------- Auto-fix common issues found by the DB consistency checker Bugs: AMBARI-18990 https://issues.apache.org/jira/browse/AMBARI-18990 Repository: ambari Description ------- Proposed auto-fixes *Inconsistency for table hostcomponentdesiredstate and hostcomponentstate for stack upgrade. *Deleted services cause config table inconsistent *Primary key constrain issue from old Ambari version *Schema name in postgres is not ambari *Inconsistency view # If there are missing states (service, component, host), etc, then automatically add one with a value of UNKNOWN or INSTALLED. # If there are no selected configs, then select the latest ones (could be a bit dangerous) # If there are multiple selected configs for the same type, then unselect all but the most recent (could be a bit dangerous) For dangerous options, by default fail with warning, and provide console option to perform fixes anyway (like the fsck does) Diffs (updated) ----- ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java 9c3ae5ce6a ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java 6fa36d467a ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java 1f2a6947ca ambari-server/src/main/python/ambari-server.py ee6259be04 ambari-server/src/main/python/ambari_server_main.py b35cfc984f Diff: https://reviews.apache.org/r/54080/diff/ Testing (updated) ------- Checked on live cluster Thanks, Dmitro Lisnichenko