----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157257 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java (lines 129 - 134) <https://reviews.apache.org/r/54145/#comment227784> What are the implications of a missing config in these new cases? Let's say that I wanted the condition to be `not-equals` to `foo-site/bar`, yet either `foo-site` or `bar` is missing or not defined. In this case, I would say that yes, its not equal because its missing. However, I don't believe that the code would get this far since it would return false immediately. ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 41) <https://reviews.apache.org/r/54145/#comment227783> Agreed - we can change this message now since it's only activated by the config being not equal. - Jonathan Hurley On Nov. 28, 2016, 10:22 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54145/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2016, 10:22 p.m.) > > > Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, > and Tim Thorpe. > > > Bugs: AMBARI-19006 > https://issues.apache.org/jira/browse/AMBARI-19006 > > > Repository: ambari > > > Description > ------- > > Today, the Express Upgrade packs message users to stop YARN queues if they do > not have work preserving recovery enabled. > However, there's no message reminding users to enable it again. > > E.g., > ``` > <group xsi:type="cluster" name="START_YARN_QUEUES" title="Start YARN > Queues 2"> > <service-check>false</service-check> > <skippable>true</skippable> > <parallel-scheduler/> > > <execute-stage service="YARN" component="RESOURCEMANAGER" title="Start > YARN Queues"> > <condition xsi:type="config" type="yarn-site" > property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" > comparison="not-equal"/> > <task xsi:type="manual"> > <message>Before continuing, please start all YARN queues if you > stopped them in a previous step.</message> > </task> > </execute-stage> > </group> > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java > 1bd88e4 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > d824309 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 882e78b > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 994203d > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > 3233f7e > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > b7d7983 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > f96f58e > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 1a26e59 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > 414ce15 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > fc4c8c5 > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > d34d476 > ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa > > Diff: https://reviews.apache.org/r/54145/diff/ > > > Testing > ------- > > Tested manually during EU from HDP 2.5 to 2.6 > > > Thanks, > > Alejandro Fernandez > >
