----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54145/#review157398 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java (line 149) <https://reviews.apache.org/r/54145/#comment228000> Usually the return value for EQUALS != NOT_EQUALS. In this case if the property doesn't exist the return values will be the same. For NOT_EQUALS, there are really 2 cases. The obvious one where the property exists and the more difficult one where the property doesn't exist. When the property doesn't exist, it would be much better if we could provide a default value to compare. <condition xsi:type="config" type="yarn-site" property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" comparison="not-equals" default="false"/> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml (line 420) <https://reviews.apache.org/r/54145/#comment227999> Duplicates? With this section, do you really need the following section as well: <group xsi:type="cluster" name="MANUAL_STEPS" title="Finishing Upgrade"> <direction>UPGRADE</direction> <execute-stage service="YARN" component="RESOURCEMANAGER" title="Start YARN Queues"> <task xsi:type="manual"> <message>Please start previously stopped YARN queues.</message> - Tim Thorpe On Nov. 29, 2016, 11:29 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54145/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2016, 11:29 p.m.) > > > Review request for Ambari, Di Li, Jonathan Hurley, Nate Cole, Sumit Mohanty, > and Tim Thorpe. > > > Bugs: AMBARI-19006 > https://issues.apache.org/jira/browse/AMBARI-19006 > > > Repository: ambari > > > Description > ------- > > Today, the Express Upgrade packs message users to stop YARN queues if they do > not have work preserving recovery enabled. > However, there's no message reminding users to enable it again. > > E.g., > ``` > <group xsi:type="cluster" name="START_YARN_QUEUES" title="Start YARN > Queues 2"> > <service-check>false</service-check> > <skippable>true</skippable> > <parallel-scheduler/> > > <execute-stage service="YARN" component="RESOURCEMANAGER" title="Start > YARN Queues"> > <condition xsi:type="config" type="yarn-site" > property="yarn.resourcemanager.work-preserving-recovery.enabled" value="true" > comparison="not-equal"/> > <task xsi:type="manual"> > <message>Before continuing, please start all YARN queues if you > stopped them in a previous step.</message> > </task> > </execute-stage> > </group> > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ConfigurationCondition.java > 1bd88e4 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > d824309 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > 882e78b > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > 1d964f8 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > fe2598b > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > b7d7983 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > ea9c60c > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > 6597cde > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml > 414ce15 > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > fc4c8c5 > > ambari-server/src/main/resources/stacks/HDP/2.6/upgrades/nonrolling-upgrade-2.6.xml > d34d476 > ambari-server/src/main/resources/upgrade-pack.xsd 45cf5fa > > Diff: https://reviews.apache.org/r/54145/diff/ > > > Testing > ------- > > Tested manually during EU from HDP 2.5 to 2.6 > > > Thanks, > > Alejandro Fernandez > >
