-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/
-----------------------------------------------------------
(Updated Dec. 7, 2016, 7:45 p.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle.
Changes
-------
2nd revision of the patch completely changes the approach of the fix.
With this patch:
1) EntityManager find operation is done only once using primary id for each
Stage and Request when they are being first loaded in the cache (maps in
TaskUpdateListener.java)
2) EntityManager merge operation is done anytime when a stage/request's status
or display status is detected to have been transitioned.
3) All the tasks, stages and requests are removed from cache if running request
is considered to have been finished
4) Both status and display_status is being persisted for stage and request
where stage denotes logical value of the completion of the intent with which
request/stage was started. Thus it take into account role success criteria,
skippable and auto skip failure values if set. On the other hand display_status
only bubles up tasks individual status to stage and request and thus helps to
navigate requests which has any kind of failed tasks.
Bugs: AMBARI-18868
https://issues.apache.org/jira/browse/AMBARI-18868
Repository: ambari
Description
-------
Stage and Request status should be persisted in the database.
upgrading to ambari-3.0.0 should add status for all present stages and request
for the cluster.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
2c87583
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
e80b020
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
31e11c1
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
319d72d
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
3c415df
ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskUpdateListener.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskUpdateEventPublisher.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
02c4091
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
1c4d0a3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java
d2f899f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
b1aad00
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
f9c8810
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java
0c227bc
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
4f90ef3
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d8cad6f
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
f86c02e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
8efcc61
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
baec7df
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskUpdateListenerTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java
cc49cbd
ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java
2fb57d7
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
d7979e8
Diff: https://reviews.apache.org/r/53686/diff/
Testing
-------
Verified manually on a cluster by making api requests and upgrading ambari.
Add unit tests.
Jenkins job overall unit test result pending..
Thanks,
Jaimin Jetly
