-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53686/
-----------------------------------------------------------
(Updated Dec. 14, 2016, 2:06 a.m.)
Review request for Ambari, Jonathan Hurley, Nate Cole, and Sid Wagle.
Changes
-------
Updated revision of the patch addresses issues raised in the last review.
After testing last patch on large cluster made more changes to do less
computation. This also includes adding validation for HostRoleStatus transition
for reported tasks. As part of this new patch, status transition of a
hostrolecommand entity from one completed state to another is considered
invalid and is ignored with appropriate logging.
Note: in-memory status change of HRC from one completed state to another
(FAILED->SKIP_FAILED) is still thought to be a valid scenario but once a
completed status of HRC is merged in HRC entity subsequent attempts of setting
it to any another state is considered to be invalid.
New patch also changes the StageDAO to query in progress stages by looking at
persisted stage status rather than doing subquery on host role command table.
Bugs: AMBARI-18868
https://issues.apache.org/jira/browse/AMBARI-18868
Repository: ambari
Description
-------
Stage and Request status should be persisted in the database.
upgrading to ambari-3.0.0 should add status for all present stages and request
for the cluster.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionDBAccessorImpl.java
2c87583
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ActionScheduler.java
e80b020
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/HostRoleStatus.java
3656bfe
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Request.java
31e11c1
ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java
4a05b32
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/CalculatedStatus.java
3c415df
ambari-server/src/main/java/org/apache/ambari/server/events/TaskCreateEvent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/TaskEvent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/TaskUpdateEvent.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListener.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/events/publishers/TaskEventPublisher.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostRoleCommandDAO.java
02c4091
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RequestDAO.java
1c4d0a3
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/StageDAO.java
d2f899f
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/HostRoleCommandEntity.java
74271b9
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/RequestEntity.java
7944d21
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntity.java
f9c8810
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/StageEntityPK.java
9ca0470
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
4f90ef3
ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 8cf2c0d
ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 82ce31e
ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql e2c2dd5
ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql 4e9a535
ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 0ba7df6
ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql d8cad6f
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionDBAccessorImpl.java
1ca777d
ambari-server/src/test/java/org/apache/ambari/server/actionmanager/TestActionScheduler.java
f86c02e
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
e23ba62
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeSummaryResourceProviderTest.java
baec7df
ambari-server/src/test/java/org/apache/ambari/server/events/listeners/tasks/TaskStatusListenerTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/UpgradeDAOTest.java
cc49cbd
ambari-server/src/test/java/org/apache/ambari/server/state/services/RetryUpgradeActionServiceTest.java
7dd9932
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
d7979e8
Diff: https://reviews.apache.org/r/53686/diff/
Testing
-------
Verified manually on a cluster by making api requests and upgrading ambari.
Add unit tests.
Jenkins job overall unit test result pending..
Thanks,
Jaimin Jetly
