> On Jan. 10, 2017, 8:18 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java, > > lines 142-144 > > <https://reviews.apache.org/r/55396/diff/1/?file=1602011#file1602011line142> > > > > Is it possible that this method and > > onServiceComponentEvent(ServiceComponentInstalledEvent event) might get > > called concurrently by the bus dispatcher? If so, we might need a lock. > > Nate Cole wrote: > Will check.
The publisher uses an AsyncEventBus with one execution thread, and the methods DON'T have @AllowConcurrentEvents, so they would be run serially anyway. I think we're good (and, I'd be amazed if we ever simultaneously added and removed a host component for the same host) - Nate ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/#review161162 ----------------------------------------------------------- On Jan. 10, 2017, 6:59 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55396/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 6:59 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-19450 > https://issues.apache.org/jira/browse/AMBARI-19450 > > > Repository: ambari > > > Description > ------- > > On initial install, we are creating host_version records that may or may not > have any versionable components. As we add host components, check if there > are any versionable components left on the host. If there are none, mark the > entity with a repo state of NOT_REQUIRED. > > (Removing the host_version records seemed very dangerous to do at this stage > of the release, so I'll make a new jira for that). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > dabd348 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 3592668 > > Diff: https://reviews.apache.org/r/55396/diff/ > > > Testing > ------- > > Manual. Automated pending. > > > Thanks, > > Nate Cole > >
