----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55396/#review161271 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java (line 90) <https://reviews.apache.org/r/55396/#comment232506> I think this is the right move, even though the bus is single-threaded (for now). Will prevent issues in the future and doesn't hurt the synchronized nature of the event handling method today. Could you add a comment why this lock was needed - it might not be obvious to anyone else looking. - Jonathan Hurley On Jan. 11, 2017, 12:04 p.m., Nate Cole wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55396/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2017, 12:04 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko and Jonathan Hurley. > > > Bugs: AMBARI-19450 > https://issues.apache.org/jira/browse/AMBARI-19450 > > > Repository: ambari > > > Description > ------- > > On initial install, we are creating host_version records that may or may not > have any versionable components. As we add host components, check if there > are any versionable components left on the host. If there are none, mark the > entity with a repo state of NOT_REQUIRED. > > (Removing the host_version records seemed very dangerous to do at this stage > of the release, so I'll make a new jira for that). > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ExecutionCommandWrapper.java > f38348b > > ambari-server/src/main/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListener.java > dabd348 > > ambari-server/src/test/java/org/apache/ambari/server/events/listeners/upgrade/HostVersionOutOfSyncListenerTest.java > 3592668 > > ambari-server/src/test/java/org/apache/ambari/server/state/cluster/ClusterTest.java > 294519e > > Diff: https://reviews.apache.org/r/55396/diff/ > > > Testing > ------- > > Manual. Automated: > > Results : > > Tests run: 4843, Failures: 0, Errors: 0, Skipped: 38 > > > Thanks, > > Nate Cole > >
