-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/#review161758
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 (line 68)
<https://reviews.apache.org/r/55538/#comment233053>

    Please replace
          shutil.move(src_provider_path, dest_provider_path)
            File(dest_provider_path,
              owner = params.oozie_user,
              group = params.user_group,
              mode = 0640
            )
            
    into
    
            File(dest_provider_path,
              owner = params.oozie_user,
              group = params.user_group,
              mode = 0640,
              content = StaticFile(src_provider_path)
            )


- Andrew Onischuk


On Jan. 16, 2017, 5:30 p.m., Nahappan Somasundaram wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55538/
> -----------------------------------------------------------
> 
> (Updated Jan. 16, 2017, 5:30 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19545
>     https://issues.apache.org/jira/browse/AMBARI-19545
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
> to desired location
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
>  21135ea5c65563716dc1fe5db0d533970d9fdb53 
> 
> Diff: https://reviews.apache.org/r/55538/diff/
> 
> 
> Testing
> -------
> 
> ** 1. Manual testing **
> 
> Deployed all the modified files to a VM and manually verified that the JCEKS 
> files were generated at the location specified in the configuration, and that 
> the ACLs were also applied correctly.
> 
> ** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **
> 
> Audit done.
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] 
> ------------------------------------------------------------------------
> [INFO] Total time: 36.153s
> [INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
> [INFO] Final Memory: 56M/603M
> [INFO] 
> ------------------------------------------------------------------------
> 
> 
> Thanks,
> 
> Nahappan Somasundaram
> 
>

Reply via email to