-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55538/
-----------------------------------------------------------

(Updated Jan. 17, 2017, 5:03 p.m.)


Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
-------

Fixed UT failure. Added comments to security_commons function.


Bugs: AMBARI-19545
    https://issues.apache.org/jira/browse/AMBARI-19545


Repository: ambari


Description
-------

AMBARI-19545: Ambari-agent - In HIVE and OOZIE stack scripts, copy JCEKS file 
to desired location


Diffs (updated)
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
 8282dc547f6bdbea3236f2dcc65e740354f41f74 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 4ac3f8eedbdf954795417f2ba6a3406ed677fcaf 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 82bb30179009d91a1dcc31d1c5c361ef4eea08a9 

Diff: https://reviews.apache.org/r/55538/diff/


Testing
-------

** 1. Manual testing **

Deployed all the modified files to a VM and manually verified that the JCEKS 
files were generated at the location specified in the configuration, and that 
the ACLs were also applied correctly.

** 2. mvn test -Dtest=ServicePropertiesTest -DskipPythonTests **

Audit done.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36.153s
[INFO] Finished at: Sat Jan 14 11:59:43 PST 2017
[INFO] Final Memory: 56M/603M
[INFO] ------------------------------------------------------------------------


Thanks,

Nahappan Somasundaram

Reply via email to