-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55983/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and
Sebastian Toader.
Bugs: AMBARI-19712
https://issues.apache.org/jira/browse/AMBARI-19712
Repository: ambari
Description
-------
`RetryHelper` already invalidates the in-memory cluster data and re-loads it
from the DB after the exception, we just need to ensure that the database has
consistent state (all or nothing), safe for retry.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
0b3869bfc0a84246c78f47016edefde74136604d
ambari-server/src/main/java/org/apache/ambari/server/state/ServiceComponentImpl.java
236091b9180a9c4279ee061d7138853333ab7610
Diff: https://reviews.apache.org/r/55983/diff/
Testing
-------
Manual testing: simulated database failure by throwing `DatabaseException` with
some probability, verified that cluster creation was successful with retries.
Existing unit tests:
```
$ mvn -am -pl ambari-server -Dcheckstyle.skip clean test
...
Tests run: 4882, Failures: 0, Errors: 0, Skipped: 38
...
Total run:1179
Total errors:0
Total failures:0
OK
...
[INFO] BUILD SUCCESS
```
Thanks,
Attila Doroszlai
