> On Feb. 14, 2017, 4:54 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java, > > line 780 > > <https://reviews.apache.org/r/56540/diff/2/?file=1633274#file1633274line780> > > > > I thought Logger uses {} for the replacement token? I wonder if this > > ever worked.
Sure, and it works. This line does not originate from me, I simply changed LOG.error(...) to error(...). - Balázs Bence ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165527 ----------------------------------------------------------- On Feb. 14, 2017, 3:27 p.m., Balázs Bence Sári wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56540/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 3:27 p.m.) > > > Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, > Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19957 > https://issues.apache.org/jira/browse/AMBARI-19957 > > > Repository: ambari > > > Description > ------- > > Postgres allows multiple schemas on a database user's search path, that is > users can query from tables in different schemas without the need of > prefixing the tables in the query. > > This can lead to confusion when after an unsuccessful upgrade DBA's restore > the tables into a different schema (e.g. public) to Ambari's configured one. > As a result, Ambari server may see different data than indended. > > New consistency checks on server startup warn the user in such situations. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java > 7aa8652 > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java > 2aaaadd > > ambari-server/src/main/java/org/apache/ambari/server/checks/IncompatibleSchemaException.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java > 1704546 > ambari-server/src/main/python/ambari_server_main.py 7a21333 > > ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java > f73562d > > Diff: https://reviews.apache.org/r/56540/diff/ > > > Testing > ------- > > - Wrote new unit tests > - Run all tests for ambari-server (all passed) > - Performed manual testing > > > Thanks, > > Balázs Bence Sári > >
