-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56540/
-----------------------------------------------------------

(Updated Feb. 15, 2017, 11:33 a.m.)


Review request for Ambari, Attila Doroszlai, Attila Magyar, Jonathan Hurley, 
Laszlo Puskas, Oliver Szabo, Sandor Magyari, and Sebastian Toader.


Changes
-------

Fixed review comments.


Bugs: AMBARI-19957
    https://issues.apache.org/jira/browse/AMBARI-19957


Repository: ambari


Description
-------

Postgres allows multiple schemas on a database user's search path, that is 
users can query from tables in different schemas without the need of prefixing 
the tables in the query. 

This can lead to confusion when after an unsuccessful upgrade DBA's restore the 
tables into a different schema (e.g. public) to Ambari's configured one. As a 
result, Ambari server may see different data than indended.

New consistency checks on server startup warn the user in such situations.


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
 7aa8652 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckResult.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyChecker.java
 2aaaadd 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariServer.java
 1704546 
  ambari-server/src/main/python/ambari_server_main.py 7a21333 
  
ambari-server/src/test/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelperTest.java
 f73562d 

Diff: https://reviews.apache.org/r/56540/diff/


Testing
-------

- Wrote new unit tests
- Run all tests for ambari-server (all passed)
- Performed manual testing


Thanks,

Balázs Bence Sári

Reply via email to