> On March 8, 2017, 9:22 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
> > Lines 160 (patched)
> > <https://reviews.apache.org/r/57419/diff/1/?file=1659216#file1659216line160>
> >
> >     I wasn't aware we supported multiple messages.
> >     How does this look like on the UI?

It adds in a line break. So each message will appear on a separate line.  
Basically it is just formatted better for reading.  Hopefully more people will 
actually look at the details then.


- Tim


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57419/#review168335
-----------------------------------------------------------


On March 8, 2017, 2:13 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57419/
> -----------------------------------------------------------
> 
> (Updated March 8, 2017, 2:13 p.m.)
> 
> 
> Review request for Ambari and Tim Thorpe.
> 
> 
> Bugs: AMBARI-20347
>     https://issues.apache.org/jira/browse/AMBARI-20347
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> it's currently displayed as one paragraph, it's clearer to display the 
> instruction in sections. this is to update upgrade xml files for such display.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  396bf30 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  b95bae5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  be2694e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml
>  68b4ce0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  1e6c18a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  a6c595a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml
>  a1bf456 
> 
> 
> Diff: https://reviews.apache.org/r/57419/diff/1/
> 
> 
> Testing
> -------
> 
> patch trunk cluster, run EU and RU, verify the messages are shown as sections 
> instead of one long paragraph.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to