> On March 8, 2017, 9:33 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > > Line 156 (original), 156 (patched) > > <https://reviews.apache.org/r/57419/diff/1/?file=1659216#file1659216line156> > > > > Can we accept HTML formatting instead? I think that lends itself to > > better support in the long-run for things like items in bold, links, etc. > > > > Perhaps as a feature request.
Multiple message blocks are already supported without any additional coding. This change will at least improve the look of the manual steps until we add HTML formatting support. Agreed that HTML formatting is better in the long run. - Tim ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57419/#review168339 ----------------------------------------------------------- On March 8, 2017, 2:13 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57419/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 2:13 p.m.) > > > Review request for Ambari and Tim Thorpe. > > > Bugs: AMBARI-20347 > https://issues.apache.org/jira/browse/AMBARI-20347 > > > Repository: ambari > > > Description > ------- > > it's currently displayed as one paragraph, it's clearer to display the > instruction in sections. this is to update upgrade xml files for such display. > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml > 396bf30 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml > b95bae5 > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml > be2694e > > ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.6.xml > 68b4ce0 > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml > 1e6c18a > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml > a6c595a > > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.6.xml > a1bf456 > > > Diff: https://reviews.apache.org/r/57419/diff/1/ > > > Testing > ------- > > patch trunk cluster, run EU and RU, verify the messages are shown as sections > instead of one long paragraph. > > > Thanks, > > Di Li > >
