----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57674/#review169742 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java Lines 267 (patched) <https://reviews.apache.org/r/57674/#comment242293> I'm still unclear on the problem. In Ambari Upgrade Catalog 212, override_hbase_uid should be removed from hbase-env since instead it is now controlled by override_uid in cluster-env. Looks like your logic may even change cluster-env's override_uid from true to false, so changing the behavior on existing clusters. Can you elaborate more? Also, this is going into trunk, so the chances of someone upgrading from Ambari 2.0 to 2.1 or higher usingn this version are extremely unlikely. - Alejandro Fernandez On March 16, 2017, 2:15 a.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57674/ > ----------------------------------------------------------- > > (Updated March 16, 2017, 2:15 a.m.) > > > Review request for Ambari, Alejandro Fernandez and Tim Thorpe. > > > Bugs: AMBARI-20461 > https://issues.apache.org/jira/browse/AMBARI-20461 > > > Repository: ambari > > > Description > ------- > > This is an issue specifically for custom stacks that may not have > override_hbase_uid property in hbase-env.xml. In this case, override_uid is > currently set to true by Ambari's auto merge logic. it should be set to false > when upgrading Ambari 2.1 to 2.2 or newer with custom stacks in order to > respect the existing UID customers already set on their clusters. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog212.java > 499c726 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog212Test.java > 3f7bcc8 > > > Diff: https://reviews.apache.org/r/57674/diff/1/ > > > Testing > ------- > > unit tests. install an Ambari 2.1 cluster with my custom stack where HBase > does not have override_hbase_uid property. build Ambari rpm from trunk code, > run ambari upgrade, verify override_uid is set to false in cluster-env, so > that UIDs that I already set on my cluster are respected. > > > Thanks, > > Di Li > >
