> On March 23, 2017, 4:41 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml > > Line 146 (original), 146 (patched) > > <https://reviews.apache.org/r/57875/diff/1/?file=1672629#file1672629line146> > > > > Why isn't this in HDFS in common-services? > > If it will not be added to that, it should still belong in HDFS in HDP > > 3.0
It is already in common-services and in 3.0. However I see that in 3.0 the path doesn't contain architecture substition. Add it as an additional commit, since the patch is already committed. Thanks for finding it. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57875/#review169890 ----------------------------------------------------------- On March 23, 2017, 1:48 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57875/ > ----------------------------------------------------------- > > (Updated March 23, 2017, 1:48 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20543 > https://issues.apache.org/jira/browse/AMBARI-20543 > > > Repository: ambari > > > Description > ------- > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml > 5be2b74 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml > b6c3738 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml > 24e0193 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml > 768ca82 > > > Diff: https://reviews.apache.org/r/57875/diff/1/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
