> On March 30, 2017, 9:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > > Line 371 (original), 371 (patched) > > <https://reviews.apache.org/r/57875/diff/2/?file=1681192#file1681192line371> > > > > Should not hardcode /usr/hdp inside common-services > > Consider using a variable like {{stack_root}}
Sure fixing in a separate jira for 2.5.1 > On March 30, 2017, 9:26 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml > > Line 177 (original), 177 (patched) > > <https://reviews.apache.org/r/57875/diff/2/?file=1681193#file1681193line177> > > > > Same comment, and in other locations. same. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57875/#review170645 ----------------------------------------------------------- On March 30, 2017, 9:10 p.m., Andrew Onischuk wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57875/ > ----------------------------------------------------------- > > (Updated March 30, 2017, 9:10 p.m.) > > > Review request for Ambari and Vitalyi Brodetskyi. > > > Bugs: AMBARI-20543 > https://issues.apache.org/jira/browse/AMBARI-20543 > > > Repository: ambari > > > Description > ------- > > . > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/configuration/hadoop-env.xml > 89d5001 > > ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml > d7031e1 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration-mapred/mapred-site.xml > bda7bcb > > ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hadoop-env.xml > f5da323 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hadoop-env.xml > d9101c6 > > ambari-server/src/main/resources/stacks/HDP/2.4/services/HDFS/configuration/hadoop-env.xml > d95460b > > ambari-server/src/main/resources/stacks/HDP/2.6/services/HDFS/configuration/hadoop-env.xml > 491c01f > > > Diff: https://reviews.apache.org/r/57875/diff/2/ > > > Testing > ------- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
