-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58079/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo Puskas, 
Robert Levas, and Sebastian Toader.


Bugs: AMBARI-20596
    https://issues.apache.org/jira/browse/AMBARI-20596


Repository: ambari


Description
-------

A tar.gz file is generated during client configuration download. This file is 
not cleand up and its file permission is world-readable, which may be a 
security risk. I changed the permission to owner-readable.


Diffs
-----

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
fad14fd 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py b2636ab 


Diff: https://reviews.apache.org/r/58079/diff/1/


Testing
-------

modified existing unittest, tested client config download manually:
 - created cluster with yarn
 - downloaded client configuration
 - checked file permission

[root@c6401 vagrant]# ls -al /var/lib/ambari-server/data/tmp/*.tar.gz
-rw------- 1 root root 6834 Mar 31 11:53 
/var/lib/ambari-server/data/tmp/YARN_CLIENT-configs.tar.gz


existing tests: pending


Thanks,

Attila Magyar

Reply via email to