-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58079/
-----------------------------------------------------------
(Updated March 31, 2017, 3:57 p.m.)
Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Laszlo Puskas,
Robert Levas, and Sebastian Toader.
Changes
-------
cleaning up command json files
Bugs: AMBARI-20596
https://issues.apache.org/jira/browse/AMBARI-20596
Repository: ambari
Description (updated)
-------
A tar.gz file is generated during client configuration download. This file is
not cleand up and its file permission is world-readable, but should be
owner-readable.
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py
fad14fd
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
e98c062
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
8f0c66f
ambari-server/src/test/python/stacks/2.0.6/HDFS/test_hdfs_client.py b2636ab
Diff: https://reviews.apache.org/r/58079/diff/2/
Changes: https://reviews.apache.org/r/58079/diff/1-2/
Testing
-------
modified existing unittest, tested client config download manually:
- created cluster with yarn
- downloaded client configuration
- checked file permission
[root@c6401 vagrant]# ls -al /var/lib/ambari-server/data/tmp/*.tar.gz
-rw------- 1 root root 6834 Mar 31 11:53
/var/lib/ambari-server/data/tmp/YARN_CLIENT-configs.tar.gz
existing tests: passed
Thanks,
Attila Magyar