> On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > > Lines 219 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686583#file1686583line219> > > > > We should not hardcode any stack name or path. > > If HDP stack needs to use "/usr/hdf", then consider passing a variable > > to this function to overwrite the default stack_root. > > > > Even in traditional HDP stacks, /usr/hdf will not exist. > > Jayush Luniya wrote: > Madhu, we can handle the RANGER changes in a separate JIRA and let RANGER > team drive that change. I also see some deadcode that needs to be removed.
Removed this file from the list of changes > On April 10, 2017, 5:19 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > > Lines 87 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line87> > > > > If any are missing, throw an error. > > Right now, this will pass if stay stack_selector_path is non null but > > component_name is null Hi Alejandro, The existing code checks for component_name argument too. if not stack_selector_path: Logger.error("Stack selector path not provided") elif not os.path.exists(stack_selector_path): Logger.error("Stack selector path does not exist") elif not component_name: Logger.error("Component name not provided") else: tmpfile = tempfile.NamedTemporaryFile() ... - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171447 ----------------------------------------------------------- On April 12, 2017, 4:54 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 4:54 a.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMBARI-20696 > > > Repository: ambari > > > Description > ------- > > The custom services do not advertise any version and hence will not > participate in the HDP upgrade process. So selectors need not be called. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b985f > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > ff00a1f38e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 0d1ef13c21 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d5018f55b2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > e42bd45cc1 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 1609050409 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 71a02f5e5a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e089102 > > > Diff: https://reviews.apache.org/r/58277/diff/3/ > > > Testing > ------- > > Installed HDP Regular services with HDF Custom services - Nifi, Strealine, > Registry > Python unit tests > Java unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >
