> On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > > Lines 49 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686585#file1686585line49> > > > > Please create a follow-up Jira to set this to False. > > I'm ok if this is a temporary patch to unblock some testing.
I have created a follow-up jira and will work on any regressions that might cause the defaults as false. > On April 11, 2017, 10:09 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > > Lines 102 (patched) > > <https://reviews.apache.org/r/58277/diff/1/?file=1686586#file1686586line102> > > > > Perhaps check that code is 0 and file length is non-zero before getting > > file contents. There is a follow up check- if code != 0 or out is None: - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171639 ----------------------------------------------------------- On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > ----------------------------------------------------------- > > (Updated April 12, 2017, 6:04 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMBARI-20696 > > > Repository: ambari > > > Description > ------- > > The custom services do not advertise any version and hence will not > participate in the HDP upgrade process. So selectors need not be called. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_select.py > 79393b985f > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 02ae62daf3 > > ambari-common/src/main/python/resource_management/libraries/functions/version_select_util.py > ff00a1f38e > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > 0d1ef13c21 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java > d5018f55b2 > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 751ce085d8 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java > e42bd45cc1 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/configuration/hive-env.xml > ad668a2051 > > ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/configuration/hive-env.xml > 872120cc55 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-INSTALL/scripts/shared_initialization.py > 1609050409 > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelperTest.java > 71a02f5e5a > > ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerTest.java > 554e089102 > > > Diff: https://reviews.apache.org/r/58277/diff/5/ > > > Testing > ------- > > Installed HDP Regular services with HDF Custom services - Nifi, Strealine, > Registry > Python unit tests > Java unit tests > > > Thanks, > > Madhuvanthi Radhakrishnan > >
