----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review172219 -----------------------------------------------------------
ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py Line 49 (original), 49 (patched) <https://reviews.apache.org/r/58489/#comment245319> I believe you will need to fix the unit test command.json files to set the versionAdvertised correctly otherwise it will cause the unit tests to fail. - Jayush Luniya On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 12:31 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > ------- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 03f53d490b > > > Diff: https://reviews.apache.org/r/58489/diff/1/ > > > Testing > ------- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
