----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58489/#review172222 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py Line 72 (original) <https://reviews.apache.org/r/58489/#comment245323> Also fix the get_stack_version.py to add null check for stack_selector_path diff --git a/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py b/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py index 7274a598ed..6926be3c39 100644 --- a/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py +++ b/ambari-common/src/main/python/resource_management/libraries/functions/get_stack_version.py @@ -67,7 +67,7 @@ def get_stack_version(package_name): stack_selector_path = stack_tools.get_stack_tool_path(stack_tools.STACK_SELECTOR_NAME) - if not os.path.exists(stack_selector_path): + if not stack_selector_path or not os.path.exists(stack_selector_path): Logger.info('Skipping get_stack_version since " + stack_selector_tool + " is not yet available') return None # lazy fail - Jayush Luniya On April 18, 2017, 12:31 a.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > ----------------------------------------------------------- > > (Updated April 18, 2017, 12:31 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush > Luniya, Nate Cole, and Sumit Mohanty. > > > Bugs: AMBARI-20775 > https://issues.apache.org/jira/browse/AMBARI-20775 > > > Repository: ambari > > > Description > ------- > > All the commands.json files should always contain the versionAdvertised > field. If versionAdvertised is not set in command.json then we should assume > that versionAdvertised=False when calling stack_tools.py > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/stack_tools.py > 93ec0b74f5 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py > 03f53d490b > > > Diff: https://reviews.apache.org/r/58489/diff/1/ > > > Testing > ------- > > Tested for service actions: > Start > Stop > Restart > Reconfigure > Service Check > Enable HA > > > Thanks, > > Madhuvanthi Radhakrishnan > >
