----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58627/#review172753 -----------------------------------------------------------
Ship it! Ship It! - Miklos Gergely On April 21, 2017, 7:48 p.m., Robert Nettleton wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58627/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 7:48 p.m.) > > > Review request for Ambari, Miklos Gergely and Oliver Szabo. > > > Bugs: AMBARI-20819 > https://issues.apache.org/jira/browse/AMBARI-20819 > > > Repository: ambari > > > Description > ------- > > This patch resolves AMBARI-20819. > > The LogSearch Integration layer in Ambari contacts the LogSearch Portal > Server in order to obtain logging data, as well as metadata for the various > logging components. > > Generally, this information is cached, but during scale testing it was > determined that the integration layer would repeatedly make requests for > logging metadata for components which did not have the correct LogSearch > metadata in the stack definitions. This causes extra and un-necessary load > on the LogSearch server, and can make debugging the LogSearch service more > difficult, due to the amount of extraneous logs generated by LogSearch as a > result of these extra queries. > > This patch resolves this issue by implementing the following: > > 1. The LogSearchDataRetrievalService has been modified to track any > components that cause errors when the initial metadata for a given component > is requested from LogSearch. If a component has had a maximum number of > error results, the integration layer will ignore this component until the > next ambari-server restart. In addition, the service will log this condition > at the DEBUG level in ambari-server.log. > > 2. Added new unit tests to verify this change. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java > 6b484a4 > > ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalServiceTest.java > d60596b > > > Diff: https://reviews.apache.org/r/58627/diff/1/ > > > Testing > ------- > > Installed a LogSearch cluster on a local VM install, and verified that the > Ambari Integration layer for LogSearch no longer makes the extra queries to > LogSearch server (verified via logsearch-performance.json). Also enabled > DEBUG logging and verified that this condition is logged at the DEBUG level > when this condition occurs. > > Also verified that the basic functions of the LogSearch Integration layer in > Ambari are still working as expected with this patch applied. > > > Thanks, > > Robert Nettleton > >
